Issue 347103002: Fixes browser_tests with --enable-text-input-focus-manager enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347103002: Fixes browser_tests with --enable-text-input-focus-manager enabled. (Closed)

Created:
6 years, 6 months ago by Yuki

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, msw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixes browser_tests with --enable-text-input-focus-manager enabled. http://crrev.com/173803002 introduced WebView::NotifyMaybeTextInputClientChanged, but the CL missed some cases. We should be aware of more cases that the underlying web_contents may change. - When an interstitial page is attached / detached - When the render process is gone browser_tests are broken with these cases when --enable-text-input-focus-manager enabled. This CL fixes the broken tests. BUG=290701 TEST=Run browser_tests with --enable-text-input-focus-manager enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278861

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	ui/views/controls/webview/webview.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/views/controls/webview/webview.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/347103002/20001

6 years, 6 months ago (2014-06-20 19:54:46 UTC) #4

Message was sent while issue was closed.

Change committed as 278861

Expand Messages | Collapse Messages