Issue 347073003: Make our FOO::cast methods const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347073003: Make our FOO::cast methods const. (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make our FOO::cast methods const. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21916

Patch Set 3 : Rebased. Made manual cast implementations more consistent. #

Patch Set 4 : Outlined stuff. Renamed macro. #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -308 lines)			Patch
	M	src/objects.h	View	1 2 3	113 chunks	+122 lines, -205 lines	1 comment	Download
	M	src/objects-inl.h	View	1 2 3	9 chunks	+132 lines, -103 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/347073003/diff/60001/src/objects.h File src/objects.h (left): https://codereview.chromium.org/347073003/diff/60001/src/objects.h#oldcode3964 src/objects.h:3964: static inline Dictionary* cast(Object* obj) { +1 on ...

6 years, 6 months ago (2014-06-23 08:37:12 UTC) #2

Sven Panne

6 years, 6 months ago (2014-06-23 08:51:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r21916 (presubmit successful).