Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3050)

Unified Diff: content/renderer/media/rtc_video_encoder.cc

Issue 347073002: Fix DCHECK crash in RtcVideoEncoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/rtc_video_encoder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_video_encoder.cc
diff --git a/content/renderer/media/rtc_video_encoder.cc b/content/renderer/media/rtc_video_encoder.cc
index 22f17a178367b1cf923a14b9747a40f99d5e4d46..1b33fc54c90abe6881a48565c6d9fbb4aa58b513 100644
--- a/content/renderer/media/rtc_video_encoder.cc
+++ b/content/renderer/media/rtc_video_encoder.cc
@@ -521,6 +521,7 @@ RTCVideoEncoder::RTCVideoEncoder(
}
RTCVideoEncoder::~RTCVideoEncoder() {
+ DVLOG(3) << "~RTCVideoEncoder";
DCHECK(thread_checker_.CalledOnValidThread());
Release();
DCHECK(!impl_);
@@ -561,8 +562,6 @@ int32_t RTCVideoEncoder::Encode(
const webrtc::CodecSpecificInfo* codec_specific_info,
const std::vector<webrtc::VideoFrameType>* frame_types) {
DVLOG(3) << "Encode()";
- // TODO(sheu): figure out why this check fails.
- // DCHECK(thread_checker_.CalledOnValidThread());
if (!impl_) {
DVLOG(3) << "Encode(): returning impl_status_=" << impl_status_;
return impl_status_;
@@ -617,7 +616,6 @@ int32_t RTCVideoEncoder::Release() {
int32_t RTCVideoEncoder::SetChannelParameters(uint32_t packet_loss, int rtt) {
DVLOG(3) << "SetChannelParameters(): packet_loss=" << packet_loss
<< ", rtt=" << rtt;
- DCHECK(thread_checker_.CalledOnValidThread());
// Ignored.
return WEBRTC_VIDEO_CODEC_OK;
}
@@ -625,7 +623,6 @@ int32_t RTCVideoEncoder::SetChannelParameters(uint32_t packet_loss, int rtt) {
int32_t RTCVideoEncoder::SetRates(uint32_t new_bit_rate, uint32_t frame_rate) {
DVLOG(3) << "SetRates(): new_bit_rate=" << new_bit_rate
<< ", frame_rate=" << frame_rate;
- DCHECK(thread_checker_.CalledOnValidThread());
if (!impl_) {
DVLOG(3) << "SetRates(): returning " << impl_status_;
return impl_status_;
« no previous file with comments | « content/renderer/media/rtc_video_encoder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698