Issue 347053009: Merge 277856 "Do not enable network technology if not available"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347053009: Merge 277856 "Do not enable network technology if not available" (Closed)

Created:
6 years, 6 months ago by stevenjb

Modified:
6 years, 6 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

More Reviews

Description

Merge 277856 "Do not enable network technology if not available" > Do not enable network technology if not available > > We currently set a technology to 'enabling' even if it is not available. > We also enable / disable both Cellular and Wimax on the same UI element > since both are never expected to be available. > Simple fix is to ignore technologies that are not available. > > BUG=368754 > > Review URL: https://codereview.chromium.org/336313002 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279892

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chromeos/network/network_state_handler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

6 years, 6 months ago (2014-06-26 02:51:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r279892 (tree was closed).

Expand Messages | Collapse Messages