Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 347033002: Password bubble: Confirm blacklisting a site if passwords exist. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Password bubble: Confirm blacklisting a site if passwords exist. If a user blacklists a site with existing saved passwords, those passwords will be deleted. In order to ensure that a user doesn't accidentally lose data, we prompt them to inform them of the risk, and ask for confirmation of the decision. BUG=384155 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278698

Patch Set 1 #

Patch Set 2 : Layout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -11 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 3 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 5 chunks +115 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike West
Vaclav, would you mind taking an initial pass over this CL while I clean up ...
6 years, 6 months ago (2014-06-20 07:15:45 UTC) #1
vabr (Chromium)
LGTM. +1 for this improvement; I was bitten in the past, when I refused to ...
6 years, 6 months ago (2014-06-20 07:32:32 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-20 09:23:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/347033002/20001
6 years, 6 months ago (2014-06-20 09:26:44 UTC) #4
Mike West
NOTRYing. Flaky win_chromium_rel tests are killing me.
6 years, 6 months ago (2014-06-20 13:17:48 UTC) #5
Mike West
The CQ bit was unchecked by mkwst@chromium.org
6 years, 6 months ago (2014-06-20 13:17:53 UTC) #6
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-20 13:17:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/347033002/20001
6 years, 6 months ago (2014-06-20 13:18:38 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 13:20:23 UTC) #9
Message was sent while issue was closed.
Change committed as 278698

Powered by Google App Engine
This is Rietveld 408576698