Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: pkg/polymer/test/build/common.dart

Issue 346973003: Skip 'fine' messages too. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library polymer.test.build.common; 5 library polymer.test.build.common;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:barback/barback.dart'; 9 import 'package:barback/barback.dart';
10 import 'package:stack_trace/stack_trace.dart'; 10 import 'package:stack_trace/stack_trace.dart';
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 fail('error running barback: $e'); 60 fail('error running barback: $e');
61 }); 61 });
62 62
63 resultSubscription = barback.results.listen((result) { 63 resultSubscription = barback.results.listen((result) {
64 expect(result.succeeded, !errorSeen, reason: "${result.errors}"); 64 expect(result.succeeded, !errorSeen, reason: "${result.errors}");
65 }); 65 });
66 66
67 logSubscription = barback.log.listen((entry) { 67 logSubscription = barback.log.listen((entry) {
68 // Ignore info messages. 68 // Ignore info messages.
69 if (entry.level == LogLevel.INFO) return; 69 if (entry.level == LogLevel.INFO || entry.level == LogLevel.FINE) return;
70 if (entry.level == LogLevel.ERROR) errorSeen = true; 70 if (entry.level == LogLevel.ERROR) errorSeen = true;
71 // We only check messages when an expectation is provided. 71 // We only check messages when an expectation is provided.
72 if (messages == null) return; 72 if (messages == null) return;
73 73
74 var msg = '${entry.level.name.toLowerCase()}: ${entry.message}'; 74 var msg = '${entry.level.name.toLowerCase()}: ${entry.message}';
75 var span = entry.span; 75 var span = entry.span;
76 var spanInfo = span == null ? '' : 76 var spanInfo = span == null ? '' :
77 ' (${span.sourceUrl} ${span.start.line} ${span.start.column})'; 77 ' (${span.sourceUrl} ${span.start.line} ${span.start.column})';
78 var index = messagesSeen++; 78 var index = messagesSeen++;
79 expect(messagesSeen, lessThanOrEqualTo(messages.length), 79 expect(messagesSeen, lessThanOrEqualTo(messages.length),
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 198
199 'observe|lib/observe.dart': 199 'observe|lib/observe.dart':
200 'library observe;\n' 200 'library observe;\n'
201 'export "src/metadata.dart";', 201 'export "src/metadata.dart";',
202 202
203 'observe|lib/src/metadata.dart': 203 'observe|lib/src/metadata.dart':
204 'library observe.src.metadata;\n' 204 'library observe.src.metadata;\n'
205 'class ObservableProperty { const ObservableProperty(); }\n' 205 'class ObservableProperty { const ObservableProperty(); }\n'
206 'const observable = const ObservableProperty();\n', 206 'const observable = const ObservableProperty();\n',
207 }; 207 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698