Index Dart/HTML units after analysis.

pkg/analysis_server/test/index/index_test.dart

Index: pkg/analysis_server/test/index/index_test.dart
diff --git a/pkg/analysis_server/test/index/index_test.dart b/pkg/analysis_server/test/index/index_test.dart
index 11fffd3aa52b7956a8a669126869fbdc3a6810e1..38330c837b16aeade38880ee11c3332baacdd40d 100644
--- a/pkg/analysis_server/test/index/index_test.dart
+++ b/pkg/analysis_server/test/index/index_test.dart
@@ -21,12 +21,13 @@ import 'package:unittest/unittest.dart';
 import '../mocks.dart';
 import '../reflective_tests.dart';
 import 'store/single_source_container.dart';
+import 'store/memory_node_manager.dart';
 
 
 main() {
   groupSep = ' | ';
-  group('ServerIndex', () {
-    runReflectiveTests(_LocalSplitIndexTest);
+  group('LocalIndex', () {
+    runReflectiveTests(_LocalIndexTest);
   });
 }
 
@@ -42,11 +43,11 @@ Iterable<String> _toElementNames(List<Location> locations) {
 
 
 @ReflectiveTestCase()
-class _LocalSplitIndexTest {
+class _LocalIndexTest {

[Brian Wilkerson, 2014/06/25 20:57:18]

Why is this private? Nobody outside this package could ever access it anyway.

[scheglov, 2014/06/25 21:13:38]

Done.

   static final DartSdk SDK = new MockSdk();
 
   AnalysisContext context;
-  LocalSplitIndex index;
+  LocalIndex index;
   Directory indexDirectory;
   MemoryResourceProvider provider = new MemoryResourceProvider();
 
@@ -54,7 +55,10 @@ class _LocalSplitIndexTest {
     // prepare Index
     indexDirectory = Directory.systemTemp.createTempSync(
         'AnalysisServer_index');
-    index = new LocalSplitIndex(indexDirectory);
+    {
+      var nodeManager = new MemoryNodeManager();
+      index = new LocalIndex(nodeManager);
+    }

[Brian Wilkerson, 2014/06/25 20:57:18]

nit: I don't see the value of wrapping these two lines in a block, but if it's
really important to you to prevent later code from accessing 'nodeManager'
perhaps we could replace these four lines with

  index = new LocalIndex(new MemoryNodeManager());

[scheglov, 2014/06/25 21:13:38]

Inlined.

     // prepare AnalysisContext
     context = AnalysisEngine.instance.createAnalysisContext();
     context.sourceFactory = new SourceFactory(<UriResolver>[new DartUriResolver(