src/runtime.cc - Issue 346933002: Avoid crashing when Runtime_GetFrameDetails is called on a RunMicrotasks stack frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 346933002: Avoid crashing when Runtime_GetFrameDetails is called on a RunMicrotasks stack frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index b97af64f838b6c2386c4b90b914bf82f0b0a2fdf..69a30535de33a89cf2dc5aa7262c0f50163be8f5 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -11402,7 +11402,8 @@ RUNTIME_FUNCTION(Runtime_GetFrameDetails) {

// bit 1: optimized frame.

// bit 2: inlined in optimized frame

int flags = 0;

- if (*save->context() == *isolate->debug()->debug_context()) {

+ if (!save->context().is_null() &&

+ *save->context() == *isolate->debug()->debug_context()) {

flags |= 1 << 0;

}

if (is_optimized) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »