Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 346933002: Avoid crashing when Runtime_GetFrameDetails is called on a RunMicrotasks stack frame (Closed)

Created:
6 years, 6 months ago by adamk
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Avoid crashing when Runtime_GetFrameDetails is called on a RunMicrotasks stack frame See attached bug for the crash reproduction: it involves three different web platform features and having the inspector open. Not clear how feasible this is to turn into a v8 test case. BUG=385349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/runtime.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
As noted in the patch description, I'm not sure how easy this is to test ...
6 years, 6 months ago (2014-06-19 22:32:37 UTC) #1
Yang
On 2014/06/19 22:32:37, adamk wrote: > As noted in the patch description, I'm not sure ...
6 years, 6 months ago (2014-06-23 11:17:00 UTC) #2
adamk
6 years, 6 months ago (2014-06-23 17:51:22 UTC) #3
On 2014/06/23 at 11:17:00, yangguo wrote:
> On 2014/06/19 22:32:37, adamk wrote:
> > As noted in the patch description, I'm not sure how easy this is to test
inside
> > v8. I only see one mention of %GetFrameDetails under test...any suggestions
for
> > testing would be appreciated.
> 
> I have an alternative solution: https://codereview.chromium.org/332923003/

Great, I like your solution better too.

Powered by Google App Engine
This is Rietveld 408576698