Issue 346913003: Fix chrome.identity.onSignInChanged regression for sign-outs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346913003: Fix chrome.identity.onSignInChanged regression for sign-outs (Closed)

Created:
6 years, 6 months ago by Michael Courage

Modified:
6 years, 6 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix chrome.identity.onSignInChanged regression for sign-outs This change fixes a regression from r270325, allowing sign-out events to fire when the --enable-new-profile-management flag is absent, which is the default. The previous change added a check to filter out events related to non-primary accounts, but the primary account ID is not available during sign-out. Removing the filter fixes the regression. BUG=376421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278762

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	chrome/browser/extensions/api/identity/identity_api.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/346913003/1

6 years, 6 months ago (2014-06-20 17:00:57 UTC) #4

Message was sent while issue was closed.

Change committed as 278762

Expand Messages | Collapse Messages