Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 346853005: Update infobar assets. (Closed)

Created:
6 years, 6 months ago by newt (away)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update infobar assets. This also removes the yellow "warning" background variation, so all infobars now have the same background color. BUG=375379 R=dfalcantara@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278877

Patch Set 1 #

Patch Set 2 : don't break downstream infobar users #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -150 lines) Patch
D chrome/android/java/res/drawable-hdpi/dismiss.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_autofill.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/infobar_autologin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_blocked_popups.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_camera.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/infobar_close_button.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_cookie.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_desktop_notifications.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_didyoumean.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_geolocation.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/infobar_midi.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_multiple_downloads.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_plugin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_plugin_crashed.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_restore.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/infobar_savepassword.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/infobar_savepassword_autologin.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/infobar_shadow.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_theme.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_translate.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-hdpi/infobar_warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/warning.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/dismiss.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_autofill.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/infobar_autologin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_blocked_popups.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_camera.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_close_button.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_cookie.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_desktop_notifications.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_didyoumean.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_geolocation.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_midi.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_multiple_downloads.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_plugin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_plugin_crashed.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_restore.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/infobar_savepassword.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_savepassword_autologin.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_shadow.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_theme.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_translate.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/infobar_warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/warning.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-tvdpi/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-tvdpi/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-tvdpi/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-tvdpi/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-tvdpi/infobar_update_uma.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/dismiss.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_autofill.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/infobar_autologin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_blocked_popups.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_camera.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/infobar_close_button.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_cookie.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_desktop_notifications.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_didyoumean.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_geolocation.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/infobar_midi.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_multiple_downloads.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_plugin.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_plugin_crashed.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_restore.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/infobar_savepassword.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/infobar_savepassword_autologin.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/infobar_shadow.png View 1 Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_theme.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_translate.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/infobar_warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/warning.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_autofill.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_blocked_popups.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_camera.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_close_button.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_cookie.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_desktop_notifications.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/infobar_didyoumean.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_geolocation.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_midi.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_multiple_downloads.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_plugin.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_plugin_crashed.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_restore.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_savepassword_autologin.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_shadow.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_theme.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_translate.png View 1 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_warning.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_button_warning_floating.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/infobar_button_warning_full_left.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/infobar_button_warning_full_right.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/infobar_info_background.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/infobar_midi.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_warning_background.xml View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/android/java/res/layout/app_banner_view.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java View 1 1 chunk +13 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 5 chunks +12 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java View 2 chunks +5 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/MessageInfoBar.java View 1 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TwoButtonInfoBar.java View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/android/resource_id.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
PTAL
6 years, 6 months ago (2014-06-19 23:26:22 UTC) #1
gone
lgtm
6 years, 6 months ago (2014-06-20 00:21:30 UTC) #2
newt (away)
+dtrainor for OWNERS goodness
6 years, 6 months ago (2014-06-20 23:44:45 UTC) #3
Ted C
On 2014/06/20 23:44:45, newt wrote: > +dtrainor for OWNERS goodness lgtm
6 years, 6 months ago (2014-06-20 23:49:33 UTC) #4
newt (away)
6 years, 6 months ago (2014-06-21 00:15:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r278877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698