Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 346853004: Add Project to skia (Closed)

Created:
6 years, 6 months ago by sheyang
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, borenet, rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M codereview.settings View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sheyang
Hi reed@ bsalomon@, I'm working on a project to make CQ better recognize issue's project. ...
6 years, 6 months ago (2014-06-19 23:05:25 UTC) #1
bsalomon
I think this is better reviewed by Ravi or Eric.
6 years, 6 months ago (2014-06-20 12:35:47 UTC) #2
borenet
Deferring to Ravi, who has more CQ experience.
6 years, 6 months ago (2014-06-20 12:38:04 UTC) #3
rmistry
LGTM skiabuildbot was also updated in https://codereview.chromium.org/331113003/
6 years, 6 months ago (2014-06-20 12:38:21 UTC) #4
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-20 16:24:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sheyang@chromium.org/346853004/1
6 years, 6 months ago (2014-06-20 16:25:04 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 16:39:18 UTC) #7
Message was sent while issue was closed.
Change committed as 7b2b29abdb3b5900a9398615c14d3ccaca171a0c

Powered by Google App Engine
This is Rietveld 408576698