Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 346853003: Added SetUserAgentID method to QuicClient which calls crypto_config_'s (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, avd, wtc
Project:
chromium
Visibility:
Public.

Description

Added SetUserAgentID method to QuicClient which calls crypto_config_'s set_user_agent_id method. The following is the internal CL description. Add command line flags to allow enabling QUIC UDP proxying based on Chrome version modifers (canary/dev/beta/stable) included in the CHLO UAID. Command line flags to allow QUIC UDP proxying for specific Chrome versions. Merge internal change: 69473619 R=rch@chromium.org

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed wtc's comments for Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/tools/quic/quic_client.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-19 21:24:14 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-19 21:39:01 UTC) #2
wtc
Patch set 1 LGTM. https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h File net/tools/quic/quic_client.h (right): https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h#newcode149 net/tools/quic/quic_client.h:149: void SetUserAgentID(string user_agent_id) { The ...
6 years, 6 months ago (2014-06-19 22:06:38 UTC) #3
ramant (doing other things)
https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h File net/tools/quic/quic_client.h (right): https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h#newcode149 net/tools/quic/quic_client.h:149: void SetUserAgentID(string user_agent_id) { On 2014/06/19 22:06:38, wtc wrote: ...
6 years, 6 months ago (2014-06-19 22:22:41 UTC) #4
ramant (doing other things)
On 2014/06/19 22:22:41, ramant wrote: > https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h > File net/tools/quic/quic_client.h (right): > > https://codereview.chromium.org/346853003/diff/1/net/tools/quic/quic_client.h#newcode149 > ...
6 years, 6 months ago (2014-06-19 22:34:00 UTC) #5
wtc
6 years, 6 months ago (2014-06-20 00:54:13 UTC) #6
Patch set 2 LGTM.

Powered by Google App Engine
This is Rietveld 408576698