Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 346813002: Remove burst mode from VSyncMonitor. (Closed)

Created:
6 years, 6 months ago by egor.starkov
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove burst mode from VSyncMonitor. Extra vsyncs after each rendering cause 1% more power consumption. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279997

Patch Set 1 #

Patch Set 2 : Fix VSyncMonitorTest compilation. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 1 2 6 chunks +13 lines, -16 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 6 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
egor.starkov
Currently VSyncMonitor requests for 5 more vsync calls from system after every rendering, that look ...
6 years, 6 months ago (2014-06-19 13:20:21 UTC) #1
Ted C
Adding @aruslan as he added the code initially and I'm not familiar with it's purpose.
6 years, 6 months ago (2014-06-19 17:55:25 UTC) #2
aruslan
On 2014/06/19 17:55:25, Ted C wrote: > Adding @aruslan as he added the code initially ...
6 years, 6 months ago (2014-06-19 18:23:23 UTC) #3
aruslan
6 years, 6 months ago (2014-06-19 18:23:34 UTC) #4
no sievers
Yes I think it *might* cause jank if we are less aggressive in sending BeginFrame ...
6 years, 6 months ago (2014-06-19 18:52:50 UTC) #5
Sami
I think postSyntheticVSync() should make keeping the vsync going a little longer largely unnecessary, so ...
6 years, 6 months ago (2014-06-20 15:48:01 UTC) #6
no sievers
I see, so maybe this is actually better. And if |needs_begin_frame_| stays on, then we ...
6 years, 6 months ago (2014-06-20 18:31:54 UTC) #7
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 6 months ago (2014-06-23 08:35:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/346813002/1
6 years, 6 months ago (2014-06-23 08:36:05 UTC) #9
egor.starkov
On 2014/06/20 18:31:54, sievers wrote: > I see, so maybe this is actually better. And ...
6 years, 6 months ago (2014-06-23 08:39:17 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-23 12:17:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 12:20:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75649)
6 years, 6 months ago (2014-06-23 12:20:42 UTC) #13
aruslan
On 2014/06/23 08:39:17, egor.starkov wrote: > On 2014/06/20 18:31:54, sievers wrote: > > I see, ...
6 years, 6 months ago (2014-06-24 02:36:14 UTC) #14
egor.starkov
On 2014/06/24 02:36:14, aruslan wrote: > On 2014/06/23 08:39:17, egor.starkov wrote: > > On 2014/06/20 ...
6 years, 6 months ago (2014-06-24 14:16:03 UTC) #15
Yaron
rubberstamp owners lgtm sievers approval is better than mine for this
6 years, 6 months ago (2014-06-24 18:16:00 UTC) #16
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 6 months ago (2014-06-25 07:02:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/346813002/20001
6 years, 6 months ago (2014-06-25 07:05:23 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 10:43:45 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 11:02:08 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/165928)
6 years, 6 months ago (2014-06-25 11:02:09 UTC) #21
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 6 months ago (2014-06-25 11:07:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/346813002/20001
6 years, 6 months ago (2014-06-25 11:09:04 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 13:59:03 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 15:37:53 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/165974)
6 years, 6 months ago (2014-06-25 15:37:54 UTC) #26
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 6 months ago (2014-06-26 13:35:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/346813002/20001
6 years, 6 months ago (2014-06-26 13:37:06 UTC) #28
commit-bot: I haz the power
Change committed as 279997
6 years, 6 months ago (2014-06-26 13:38:30 UTC) #29
Peter Beverloo
A revert of this CL has been created in https://codereview.chromium.org/358473006/ by peter@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-26 15:22:07 UTC) #30
egor.starkov
This commit was reverted. So I've fixed the tests to follow the rule 1 request ...
6 years, 5 months ago (2014-06-27 14:00:53 UTC) #31
aruslan
lgtm - thanks for fixing the test.
6 years, 5 months ago (2014-06-27 15:47:21 UTC) #32
egor.starkov
On 2014/06/27 15:47:21, aruslan wrote: > lgtm - thanks for fixing the test. Hi Ruslan, ...
6 years, 5 months ago (2014-06-27 17:57:55 UTC) #33
aruslan
On 2014/06/27 17:57:55, egor.starkov wrote: > On 2014/06/27 15:47:21, aruslan wrote: > > lgtm - ...
6 years, 5 months ago (2014-06-27 18:02:06 UTC) #34
aruslan
On 2014/06/27 18:02:06, aruslan wrote: > On 2014/06/27 17:57:55, egor.starkov wrote: > > On 2014/06/27 ...
6 years, 5 months ago (2014-06-27 18:02:28 UTC) #35
egor.starkov
On 2014/06/27 18:02:28, aruslan wrote: > On 2014/06/27 18:02:06, aruslan wrote: > > On 2014/06/27 ...
6 years, 5 months ago (2014-06-27 18:37:04 UTC) #36
Sami
6 years, 5 months ago (2014-07-07 14:34:31 UTC) #37
Message was sent while issue was closed.
On 2014/06/27 at 18:37:04, egor.starkov wrote:
> On 2014/06/27 18:02:28, aruslan wrote:
> > On 2014/06/27 18:02:06, aruslan wrote:
> > > On 2014/06/27 17:57:55, egor.starkov wrote:
> > > > On 2014/06/27 15:47:21, aruslan wrote:
> > > > > lgtm - thanks for fixing the test.
> > > > 
> > > > Hi Ruslan, do I need to create another review to commit this patch
> > > > or I can just reopen this one and commit again through CQ?
> > > > 
> > > > Br,
> > > > Egor.
> > > 
> > > I always uploaded a new patch; may be there are simpler ways, but I'm not
> > aware
> > > of them.
> > > Once uploaded - please add a reference to this CL and add OWNERS to lgtm
the
> > > changes.
> > > 
> > > Thanks,
> > > -- Ruslan.
> > 
> > (new patch == new issue in codereview.)
> 
> Ok, thanks.

FYI, you can also re-open the old review and land the fixed patch that way
through the commit queue. Having all the revision in the same place makes it a
little easier for reviewers to see how the patch was changed.

Powered by Google App Engine
This is Rietveld 408576698