Issue 346803002: Remove KeyframeEffectModel.h include from StyleResolver.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346803002: Remove KeyframeEffectModel.h include from StyleResolver.h (Closed)

Created:
6 years, 6 months ago by davve

Modified:
6 years, 6 months ago

Reviewers:
rune

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove KeyframeEffectModel.h include from StyleResolver.h Replace the include with forward declarations. Prior to this patch, KeyframeEffectModel.h had roughly 700 targets depending on it. After this patch this number has shrunk to around 11. In the last 90 days, KeyframeEffectModel.h was modified 13 times on trunk, which is a relatively high number. KeyframeEffectModel.h also pulls in a large amount of other animation headers so they should see similar benefits. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176517

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	Source/core/css/resolver/StyleResolver.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/346803002/1

6 years, 6 months ago (2014-06-19 14:26:17 UTC) #4

Message was sent while issue was closed.

Change committed as 176517

Expand Messages | Collapse Messages