Source/web/WebViewImpl.cpp - Issue 346773004: Removing usused smartclip APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 346773004: Removing usused smartclip APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index d4067b3dd7253320b06fd63ea608c79d2f118da9..92422a6a2491494814e084c2096d9c175c60b4b0 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3498,13 +3498,6 @@ void WebViewImpl::showContextMenu()

m_contextMenuAllowed = false;

}

-// FIXME: This should be removed when the chromium side patch lands

-// http://codereview.chromium.org/260623004

-WebString WebViewImpl::getSmartClipData(WebRect rect)

- return WebString();

void WebViewImpl::getSmartClipData(WebRect rect, WebString& clipText, WebRect& clipRect)

{

LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());

« no previous file with comments | « Source/web/WebViewImpl.h ('k') | public/web/WebView.h » ('j') | no next file with comments »