Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 346773004: Removing usused smartclip APIs (Closed)

Created:
6 years, 6 months ago by AviD
Modified:
6 years, 6 months ago
CC:
abarth-chromium, AKVT, blink-reviews, dglazkov+blink, jamesr, use-l.gombos-samsung.com, Cyan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing usused smartclip APIs Related to Blink patch https://codereview.chromium.org/259263003/ Some APIs were dependent on chromium side patch. https://codereview.chromium.org/260623004/ Since both patches are landed, removing the redundant APIs BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
AviD
PTAL
6 years, 6 months ago (2014-06-23 11:40:13 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-23 17:05:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/346773004/1
6 years, 6 months ago (2014-06-23 17:06:43 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-23 18:07:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 18:46:14 UTC) #5
Message was sent while issue was closed.
Change committed as 176776

Powered by Google App Engine
This is Rietveld 408576698