Adding blacklisted dlls to safe browsing incident reports.

chrome/browser/chrome_elf_init_win.cc

Index: chrome/browser/chrome_elf_init_win.cc
diff --git a/chrome/browser/chrome_elf_init_win.cc b/chrome/browser/chrome_elf_init_win.cc
index e09d2c9c3928a28657f54831bcb777657fa13c1d..7e4c4f643bc34c7c03179b4c19d0f28b116861cf 100644
--- a/chrome/browser/chrome_elf_init_win.cc
+++ b/chrome/browser/chrome_elf_init_win.cc
@@ -113,6 +113,11 @@ void AddFinchBlacklistToRegistry() {
   if (!finch_blacklist_registry_key.Valid())
     return;
 
+  // Delete and recreate the key to clear the registry.
+  finch_blacklist_registry_key.DeleteKey(L"");
+  finch_blacklist_registry_key.Create(
+      HKEY_CURRENT_USER, blacklist::kRegistryFinchListPath, KEY_SET_VALUE);

[mattm, 2014/06/19 22:46:31]

what happens with this registry entry when multiple instances of chrome are
running at once?

[grt (UTC plus 2), 2014/06/20 00:06:27]

this is a good point. in time, we may have canary, stable, beta, and dev running
concurrently. at the moment, canary and one non-canary may be running.

[krstnmnlsn, 2014/06/20 18:02:58]

To split up the registry values by channel running would require knowing the
channel very early in start up (in blacklist.cc) and that doesn't seem easy to
do (and may require code duplication).  So, for the moment at least, I will just
add a comment explaining the situation.  
I'll also make a separate CL fixing it so that chromium is not using the same
registry key.

+
   std::map<std::string, std::string> params;
   chrome_variations::GetVariationParams(kBrowserBlacklistTrialName, &params);