Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 346753003: Revert of Move BenchTimer to tools as Timer (Closed)

Created:
6 years, 6 months ago by mtklein
Modified:
6 years, 6 months ago
Reviewers:
tfarina, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Move BenchTimer to tools as Timer (https://codereview.chromium.org/344213003/) Reason for revert: GpuTimer broken Original issue's description: > Move BenchTimer to tools as Timer > > This breaks a bunch of circular dependencies between tools and gm and bench. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed TBR=tfarina@chromium.org,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9e64b78ff687edd24c55c0e26942411468032d32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1106 lines, -930 lines) Patch
A bench/BenchGpuTimer_gl.h View 1 chunk +26 lines, -0 lines 0 comments Download
A bench/BenchGpuTimer_gl.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_c.h View 1 chunk +26 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_c.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_mach.h View 1 chunk +26 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_mach.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_posix.h View 1 chunk +25 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_posix.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_windows.h View 1 chunk +26 lines, -0 lines 0 comments Download
A bench/BenchSysTimer_windows.cpp View 1 chunk +64 lines, -0 lines 0 comments Download
A bench/BenchTimer.h View 1 chunk +67 lines, -0 lines 0 comments Download
A bench/BenchTimer.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
A bench/TimerData.h View 1 chunk +86 lines, -0 lines 0 comments Download
A bench/TimerData.cpp View 1 chunk +224 lines, -0 lines 0 comments Download
M bench/benchmain.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/apptype_console.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/bench.gyp View 2 chunks +61 lines, -3 lines 0 comments Download
A gyp/crash_handler.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/dm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/gm.gyp View 2 chunks +24 lines, -3 lines 0 comments Download
A gyp/resources.gyp View 1 chunk +25 lines, -0 lines 0 comments Download
D gyp/skia_launcher.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/tools.gyp View 8 chunks +22 lines, -89 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
D platform_tools/android/gyp/skia_launcher.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/DumpRecord.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/PictureBenchmark.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/PictureBenchmark.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/bbh_shootout.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/bench_playback.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M tools/bench_record.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M tools/skpdiff/skpdiff_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tools/timer/GpuTimer.h View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/timer/GpuTimer.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D tools/timer/SysTimer_mach.h View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/timer/SysTimer_mach.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D tools/timer/SysTimer_posix.h View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/timer/SysTimer_posix.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/timer/SysTimer_windows.h View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/timer/SysTimer_windows.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/timer/Timer.h View 1 chunk +0 lines, -73 lines 0 comments Download
D tools/timer/Timer.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D tools/timer/TimerData.h View 1 chunk +0 lines, -85 lines 0 comments Download
D tools/timer/TimerData.cpp View 1 chunk +0 lines, -220 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Move BenchTimer to tools as Timer
6 years, 6 months ago (2014-06-20 17:42:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/346753003/1
6 years, 6 months ago (2014-06-20 17:42:46 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:43:11 UTC) #3
Message was sent while issue was closed. 
Change committed as 9e64b78ff687edd24c55c0e26942411468032d32

Powered by Google App Engine
This is Rietveld 408576698