Issue 346753002: [Mac]. Increment app shortcut version.

Issue 346753002: [Mac]. Increment app shortcut version. (Closed)

Created:
6 years, 6 months ago by jackhou1

Modified:
6 years, 6 months ago

Reviewers:
tapted

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Mac]. Increment app shortcut version. This also increments the app list shortcut version. This will trigger a rebuild of all app shims. This also disables updating all shortcuts in tests. BUG=353047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278397

Patch Set 1 #

Patch Set 2 : Also rebuild app list shim. #

Total comments: 2

Patch Set 3 : Address comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/apps/shortcut_manager.cc	View		4 chunks	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/app_list/app_list_service_mac.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tapted

https://codereview.chromium.org/346753002/diff/20001/chrome/browser/web_applications/web_app_mac.mm File chrome/browser/web_applications/web_app_mac.mm (right): https://codereview.chromium.org/346753002/diff/20001/chrome/browser/web_applications/web_app_mac.mm#newcode1019 chrome/browser/web_applications/web_app_mac.mm:1019: AppListService::Get(chrome::HOST_DESKTOP_TYPE_NATIVE)->CreateShortcut(); There's kShortcutVersion in app_list_service_mac.mm - incrementing that will ...

6 years, 6 months ago (2014-06-19 07:32:04 UTC) #2

jackhou1

https://codereview.chromium.org/346753002/diff/20001/chrome/browser/web_applications/web_app_mac.mm File chrome/browser/web_applications/web_app_mac.mm (right): https://codereview.chromium.org/346753002/diff/20001/chrome/browser/web_applications/web_app_mac.mm#newcode1019 chrome/browser/web_applications/web_app_mac.mm:1019: AppListService::Get(chrome::HOST_DESKTOP_TYPE_NATIVE)->CreateShortcut(); On 2014/06/19 07:32:04, tapted wrote: > There's kShortcutVersion ...

6 years, 6 months ago (2014-06-19 07:44:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/346753002/40001

6 years, 6 months ago (2014-06-19 07:51:07 UTC) #6

Message was sent while issue was closed.

Change committed as 278397

Expand Messages | Collapse Messages