Issue 346743005: Making MigrateToMap() a single bottleneck for all migrations except slow-to-fast case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346743005: Making MigrateToMap() a single bottleneck for all migrations except slow-to-fast case. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Making MigrateToMap() a single bottleneck for all migrations except slow-to-fast case. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21984

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -5 lines)			Patch
	M	src/objects.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/objects.cc	View		5 chunks	+32 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm https://codereview.chromium.org/346743005/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/346743005/diff/1/src/objects.cc#newcode2141 src/objects.cc:2141: // To migrate an fast instance to a ...

6 years, 6 months ago (2014-06-24 13:17:33 UTC) #2

Igor Sheludko

6 years, 6 months ago (2014-06-24 15:29:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21984 (presubmit successful).

Expand Messages | Collapse Messages