Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 346743002: device/bluetooth: Send GattServiceChanged event for new Chrc. properties. (Closed)

Created:
6 years, 6 months ago by armansito
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Send GattServiceChanged event for new Chrc. properties. BluetoothRemoteGattServiceChromeOS now sends a GattServiceChanged observer event when a new value for a characteristic property is received. This is needed when the "Characteristic Extended Properties" descriptor is present for a characteristic and its value is asynchronously read by bluetoothd, which results in a PropertiesChanged signal for the "Flags" property of GattCharacteristic1. BUG=382253 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278495

Patch Set 1 #

Patch Set 2 : Simple rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 chunk +3 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
armansito
6 years, 6 months ago (2014-06-19 05:15:43 UTC) #1
keybuk
lgtm
6 years, 6 months ago (2014-06-19 17:05:07 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-19 17:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/346743002/20001
6 years, 6 months ago (2014-06-19 17:22:44 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:40:48 UTC) #5
Message was sent while issue was closed.
Change committed as 278495

Powered by Google App Engine
This is Rietveld 408576698