Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 346733003: Add experimental versions of the malware interstitial (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
Bernhard Bauer, mattm
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add experimental versions of the malware interstitial This adds a few experimental versions of the new malware interstitial. They are all teh addition of an extra string. 1. Prior history 2. "(not recommended)" next to link 3. Advice 4. Social proof BUG=386033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278618

Patch Set 1 #

Total comments: 2

Patch Set 2 : Flags override Finch #

Patch Set 3 : Tweak to "not recommended" string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -99 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +37 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/safe_browsing/safe_browsing_v3.js View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.css View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/ssl/interstitial_v2.js View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 8 chunks +108 lines, -83 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
felt
matt, bernhard, please take a look. thanks.
6 years, 6 months ago (2014-06-19 04:47:27 UTC) #1
mattm
https://codereview.chromium.org/346733003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right): https://codereview.chromium.org/346733003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc#newcode153 chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:153: base::FieldTrialList::FindFullName(kV3StudyName) == kCondV2) { Seems like the switches should ...
6 years, 6 months ago (2014-06-19 06:57:03 UTC) #2
Bernhard Bauer
lgtm
6 years, 6 months ago (2014-06-19 08:10:58 UTC) #3
felt
https://codereview.chromium.org/346733003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right): https://codereview.chromium.org/346733003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc#newcode153 chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:153: base::FieldTrialList::FindFullName(kV3StudyName) == kCondV2) { On 2014/06/19 06:57:03, mattm wrote: ...
6 years, 6 months ago (2014-06-19 14:08:54 UTC) #4
mattm
lgtm
6 years, 6 months ago (2014-06-19 22:15:36 UTC) #5
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-19 22:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/346733003/40001
6 years, 6 months ago (2014-06-19 22:55:27 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:34:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 23:43:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85645)
6 years, 6 months ago (2014-06-19 23:43:15 UTC) #10
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-19 23:43:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/346733003/40001
6 years, 6 months ago (2014-06-19 23:45:49 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:57:21 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:33:11 UTC) #14
Message was sent while issue was closed.
Change committed as 278618

Powered by Google App Engine
This is Rietveld 408576698