Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 346713003: Surface ERR_SPDY_SESSION_ALREADY_EXISTS to the proxy delegate. (Closed)

Created:
6 years, 6 months ago by Johnny
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Surface ERR_SPDY_SESSION_ALREADY_EXISTS to the proxy delegate. Add a regression test, confirming that sessions which race host resolutions don't fail network transactions. BUG=334413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278346

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Johnny
https://codereview.chromium.org/346713003/diff/1/net/http/http_proxy_client_socket_pool.cc File net/http/http_proxy_client_socket_pool.cc (right): https://codereview.chromium.org/346713003/diff/1/net/http/http_proxy_client_socket_pool.cc#newcode250 net/http/http_proxy_client_socket_pool.cc:250: return ERR_PROXY_CONNECTION_FAILED; Is there a particular rationale for converting ...
6 years, 6 months ago (2014-06-19 04:08:43 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/346713003/diff/1/net/http/http_proxy_client_socket_pool.cc File net/http/http_proxy_client_socket_pool.cc (right): https://codereview.chromium.org/346713003/diff/1/net/http/http_proxy_client_socket_pool.cc#newcode250 net/http/http_proxy_client_socket_pool.cc:250: return ERR_PROXY_CONNECTION_FAILED; On 2014/06/19 04:08:43, Johnny wrote: > ...
6 years, 6 months ago (2014-06-19 04:25:39 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 6 months ago (2014-06-19 05:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/346713003/1
6 years, 6 months ago (2014-06-19 05:10:23 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:51:53 UTC) #5
Message was sent while issue was closed.
Change committed as 278346

Powered by Google App Engine
This is Rietveld 408576698