Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 346713002: Don't set app window WS_CAPTION style when running in ash mode. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Don't set app window WS_CAPTION style when running in ash mode. This is not necessary, and causes the entire ash mode to get WS_CAPTION as ash mode shares a single HWND. BUG=385557 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278384

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
Tested on Windows 8, all seems good there.
6 years, 6 months ago (2014-06-19 07:21:10 UTC) #1
calamity
lgtm https://codereview.chromium.org/346713002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc (left): https://codereview.chromium.org/346713002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc#oldcode52 chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc:52: // This is done for launching apps, but ...
6 years, 6 months ago (2014-06-19 07:43:06 UTC) #2
benwells
https://codereview.chromium.org/346713002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc File chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc (left): https://codereview.chromium.org/346713002/diff/1/chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc#oldcode52 chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc:52: // This is done for launching apps, but not ...
6 years, 6 months ago (2014-06-19 08:33:37 UTC) #3
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-19 08:33:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/346713002/20001
6 years, 6 months ago (2014-06-19 08:35:54 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 15:26:41 UTC) #6
Message was sent while issue was closed.
Change committed as 278384

Powered by Google App Engine
This is Rietveld 408576698