Small cleanups in automation_node.js.

chrome/renderer/resources/extensions/automation/automation_node.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var AutomationEvent = require('automationEvent').AutomationEvent;
 var automationInternal =
     require('binding').Binding.create('automationInternal').generate();
 var utils = require('utils');
 var IsInteractPermitted =
     requireNative('automationInternal').IsInteractPermitted;
@@ skipping 54 matching lines @@
     var parent = this.parent();
     if (parent && this.indexInParent < parent.children().length)
       return parent.children()[this.indexInParent + 1];
     return undefined;
   },
 
   doDefault: function() {
     this.performAction_('doDefault');
   },
 
-  focus: function(opt_callback) {
+  focus: function() {
     this.performAction_('focus');
   },
 
-  makeVisible: function(opt_callback) {
+  makeVisible: function() {
     this.performAction_('makeVisible');
   },
 
-  setSelection: function(startIndex, endIndex, opt_callback) {
+  setSelection: function(startIndex, endIndex) {
     this.performAction_('setSelection',
                         { startIndex: startIndex,
                           endIndex: endIndex });
   },
 
   addEventListener: function(eventType, callback, capture) {
     this.removeEventListener(eventType, callback);
     if (!this.listeners[eventType])
       this.listeners[eventType] = [];
     this.listeners[eventType].push({callback: callback, capture: !!capture});
@@ skipping 178 matching lines @@
     var nodeImpl = privates(node).impl;
     var id = node.id;
     for (var key in AutomationAttributeDefaults) {
       nodeImpl[key] = AutomationAttributeDefaults[key];
     }
     nodeImpl.loaded = false;
     nodeImpl.id = id;
     this.axNodeDataCache_[id] = undefined;
   },
 
+  load: function(callback) {
+    // TODO(dtseng/aboxhall): Implement.
+    if (!this.loaded)
+      throw 'Unsupported state: root node is not loaded.';
+
+    callback();

[aboxhall, 2014/07/07 17:24:24]

Remember that we need to schedule the callback rather than calling it
re-entrantly.

+  },
+
   update: function(data) {
     var didUpdateRoot = false;
 
     if (data.nodes.length == 0)
       return false;
 
     for (var i = 0; i < data.nodes.length; i++) {
       var nodeData = data.nodes[i];
       var node = this.axNodeDataCache_[nodeData.id];
       if (!node) {
@@ skipping 99 matching lines @@
                                                'attributes'] });
 
 var AutomationRootNode = utils.expose('AutomationRootNode',
                                       AutomationRootNodeImpl,
                                       { superclass: AutomationNode,
                                         functions: ['load'],
                                         readonly: ['loaded'] });
 
 exports.AutomationNode = AutomationNode;
 exports.AutomationRootNode = AutomationRootNode;