Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 346673002: Ignore EnterNotify and ExitNotify events from NativeViewGlSurfaceGLX's window. (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
Reviewers:
sadrul, piman
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org, tdanderson, piman
Project:
chromium
Visibility:
Public.

Description

Ignore EnterNotify and LeaveNotify events from NativeViewGlSurfaceGLX's window. https://codereview.chromium.org/296003010 added a child window to the toplevel X window. As a result of the CL, an EnterNotify event is sent immediately after each mouse press. WindowTreeHostX11:Dispatch() transforms the EnterNotify to a synthetic mouse move. In terms of HTML events, the CL causes an 'onmousemove' event to be fired immediately after the 'onmousedown' event. This differs from the previous behavior where the initial 'onmousemove' event was always fired some indeterminate time after the 'onmousedown'. For the sake of safety, this CL suppresses the extra EnterNotify. BUG=385716 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278485

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ui/aura/window_tree_host_x11.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Sadrul, PTAL Extra info: https://x20web.corp.google.com/~pkotwicz/drag_delay/index.html is a web page which demonstrates the change in the ...
6 years, 6 months ago (2014-06-18 22:46:23 UTC) #1
piman
LGTM fwiw
6 years, 6 months ago (2014-06-18 22:51:02 UTC) #2
sadrul
lgtm
6 years, 6 months ago (2014-06-19 13:20:54 UTC) #3
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-19 13:37:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/346673002/80001
6 years, 6 months ago (2014-06-19 13:38:36 UTC) #5
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-19 13:43:41 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-19 13:44:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/346673002/80001
6 years, 6 months ago (2014-06-19 13:45:30 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 21:13:35 UTC) #9
Message was sent while issue was closed.
Change committed as 278485

Powered by Google App Engine
This is Rietveld 408576698