Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 346643002: Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel. I don't know if there are any v8 bots with that configuration, but it seems like a good idea to have v8 be consistent with chromium and nacl here, so that this works fine if such a bot is ever set up. This is similar to https://codereview.chromium.org/342493002/ , but with a detect_v8_host_arch.py script that handles the additional machine types that standalone.gypi used to handle. BUG=368384 possibly? LOG=Y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
A build/detect_v8_host_arch.py View 1 chunk +68 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
http://build.chromium.org/p/tryserver.v8/waterfall seems to ignore my `gcl try` invocation, but it seems to work locally at ...
6 years, 6 months ago (2014-06-18 21:38:40 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-18 22:49:18 UTC) #2
jochen (gone - plz use gerrit)
tryserver access is restricted to committers. Why are you using gcl? You should just "fetch ...
6 years, 6 months ago (2014-06-18 22:49:48 UTC) #3
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r21909 (presubmit successful).
6 years, 6 months ago (2014-06-23 08:20:01 UTC) #4
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-23 08:50:02 UTC) #5
Message was sent while issue was closed.
On 2014/06/23 at 08:20:01, jochen wrote:
> Committed patchset #1 manually as r21909 (presubmit successful).

broke nacl build...
http://build.chromium.org/p/client.v8/builders/NaCl%20V8%20Linux/builds/2267/...

Powered by Google App Engine
This is Rietveld 408576698