Issue 346633002: Move channel_init out of mojo_common.

Issue 346633002: Move channel_init out of mojo_common. (Closed)

Created:
6 years, 6 months ago by qsr

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review), viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move channel_init out of mojo_common. mojo_common can not depends on embedder, as standalone application must depends on it. channel_init is in fact a part of the embedder. R=viettrungluu@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278357

Patch Set 1 #

Patch Set 2 : Fix gn build #

Total comments: 2

Patch Set 3 : Follow review #

Patch Set 4 : Fix namespace #

Patch Set 5 : Fix dependencies #

Patch Set 6 : Fix exports #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -146 lines)			Patch
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/mojo/mojo_application_host.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/child/mojo/mojo_application.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/common/BUILD.gn	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/common/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/common/channel_init.h	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	mojo/common/channel_init.cc	View		1 chunk	+0 lines, -59 lines	0 comments	Download
M	mojo/dbus/dbus_external_service.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/dbus/dbus_external_service.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	mojo/embedder/channel_init.h	View	1 2 3 4 5	3 chunks	+7 lines, -7 lines	0 comments	Download
A +	mojo/embedder/channel_init.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/mojo.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/services/dbus_echo/dbus_echo_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/shell/dbus_service_loader_linux.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

https://codereview.chromium.org/346633002/diff/20001/mojo/embedder/channel_init.h File mojo/embedder/channel_init.h (right): https://codereview.chromium.org/346633002/diff/20001/mojo/embedder/channel_init.h#newcode24 mojo/embedder/channel_init.h:24: namespace common { Probably you should move it inside ...

6 years, 6 months ago (2014-06-18 20:35:04 UTC) #2

qsr

https://chromiumcodereview.appspot.com/346633002/diff/20001/mojo/embedder/channel_init.h File mojo/embedder/channel_init.h (right): https://chromiumcodereview.appspot.com/346633002/diff/20001/mojo/embedder/channel_init.h#newcode24 mojo/embedder/channel_init.h:24: namespace common { On 2014/06/18 20:35:03, viettrungluu wrote: > ...

6 years, 6 months ago (2014-06-18 20:54:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/346633002/100001

6 years, 6 months ago (2014-06-19 13:28:33 UTC) #7

Message was sent while issue was closed.

Change committed as 278357

Expand Messages | Collapse Messages