Issue 346623003: Reverse order of tests in eraseDangerousAttributeIfInjected().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346623003: Reverse order of tests in eraseDangerousAttributeIfInjected(). (Closed)

Created:
6 years, 6 months ago by Tom Sepez

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Reverse order of tests in eraseDangerousAttributeIfInjected(). The semicolon-separated case must come first to prevent it from being handled in the ordinary manner when the string starts with javascript:, since it need not obey the normal termination rules when it is first split by semicolons. BUG=384077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176478

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
A +	LayoutTests/http/tests/security/xssAuditor/svg-animate-clutter-2.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/http/tests/security/xssAuditor/svg-animate-clutter-2-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/parser/XSSAuditor.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Adam, please review. I woke up this morning and realized I'd done this wrong. The ...

6 years, 6 months ago (2014-06-18 19:37:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/346623003/1

6 years, 6 months ago (2014-06-19 02:07:11 UTC) #4

Message was sent while issue was closed.

Change committed as 176478

Expand Messages | Collapse Messages