Use loadable module instead of shared library.

mojo/mojo.gyp

Index: mojo/mojo.gyp
diff --git a/mojo/mojo.gyp b/mojo/mojo.gyp
index 69665f197132375ff41b761c02bb870514a4844d..4a49027762eddc96591096411f9b694f607405aa 100644
--- a/mojo/mojo.gyp
+++ b/mojo/mojo.gyp
@@ -16,6 +16,29 @@
   'variables': {
     'chromium_code': 1,
     'mojo_shell_debug_url%': "",
+    'common_sources': [

[viettrungluu, 2014/06/30 16:27:18]

Probably you should have a comment explaining why we have variables for these.
Something like: "We build two versions of these libraries, a version for use in
Chromium and the shell and an "embedded" version for use in loadable
apps/services.".

[qsr, 2014/07/01 08:09:35]

Done.

+      'common/common_type_converters.cc',
+      'common/common_type_converters.h',
+      'common/data_pipe_utils.cc',
+      'common/data_pipe_utils.h',
+      'common/handle_watcher.cc',
+      'common/handle_watcher.h',
+      'common/message_pump_mojo.cc',
+      'common/message_pump_mojo.h',
+      'common/message_pump_mojo_handler.h',
+      'common/time_helper.cc',
+      'common/time_helper.h',
+    ],
+    'environment_chromium_sources': [
+      'environment/default_async_waiter_impl.cc',
+      'environment/default_async_waiter_impl.h',
+      'environment/default_logger_impl.cc',
+      'environment/default_logger_impl.h',
+      'environment/environment.cc',
+      # TODO(vtl): This is kind of ugly. (See TODO in logging.h.)
+      "public/cpp/environment/logging.h",
+      "public/cpp/environment/lib/logging.h",
+    ],
   },
   'includes': [
     'mojo_apps.gypi',
@@ -30,6 +53,7 @@
       'dependencies': [
         'mojo_apps_js_unittests',
         'mojo_compositor_app',
+        'mojo_common_embedded_lib',
         'mojo_common_lib',
         'mojo_common_unittests',
         'mojo_cpp_bindings',
@@ -322,6 +346,26 @@
       ],
     },
     {
+      'target_name': 'mojo_common_embedded_lib',

[viettrungluu, 2014/06/30 16:27:17]

It'd be nice if the non-embedded and embedded versions were in the same order in
the .gyp file (e.g., non-embedded, then embedded).

You should also have comments before each along the lines of "For use in
Chromium and the shell."/"For use in loadable apps and services.".

[qsr, 2014/07/01 08:09:35]

Done.

+      'type': 'static_library',
+      'defines': [
+        'MOJO_COMMON_EMBEDDED',
+      ],
+      'dependencies': [
+        '..//base/base.gyp:base',
+        '..//base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+        'mojo_system',
+      ],
+      'sources': [
+        '<@(common_sources)',
+      ],
+      'all_dependent_settings': {
+        'defines': [
+          'MOJO_COMMON_EMBEDDED',
+        ],
+      },
+    },
+    {
       # GN version: //mojo/common
       'target_name': 'mojo_common_lib',
       'type': '<(component)',
@@ -334,21 +378,12 @@
         'mojo_system_impl',
       ],
       'export_dependent_settings': [
+        '../base/base.gyp:base',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         'mojo_system_impl',
       ],
       'sources': [
-        'common/common_type_converters.cc',
-        'common/common_type_converters.h',
-        'common/data_pipe_utils.cc',
-        'common/data_pipe_utils.h',
-        'common/handle_watcher.cc',
-        'common/handle_watcher.h',
-        'common/message_pump_mojo.cc',
-        'common/message_pump_mojo.h',
-        'common/message_pump_mojo_handler.h',
-        'common/time_helper.cc',
-        'common/time_helper.h',
+        '<@(common_sources)',
       ],
     },
     {
@@ -394,42 +429,34 @@
       'target_name': 'mojo_environment_chromium',
       'type': 'static_library',
       'dependencies': [
+        '../base/base.gyp:base',
+        '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         'mojo_common_lib',
-        'mojo_environment_chromium_impl',
-      ],
-      'sources': [
-        'environment/environment.cc',
-        # TODO(vtl): This is kind of ugly. (See TODO in logging.h.)
-        "public/cpp/environment/logging.h",
-        "public/cpp/environment/lib/logging.h",
-      ],
-      'include_dirs': [
-        '..',
+        'mojo_system_impl',
       ],
       'export_dependent_settings': [
-        'mojo_environment_chromium_impl',
+        '../base/base.gyp:base',
+        '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+      ],
+      'sources': [
+        '<@(environment_chromium_sources)',
       ],
     },
     {
-      # GN version: //mojo/environment:chromium_impl
-      'target_name': 'mojo_environment_chromium_impl',
-      'type': '<(component)',
-      'defines': [
-        'MOJO_ENVIRONMENT_IMPL_IMPLEMENTATION',
-      ],
+      'target_name': 'mojo_environment_chromium_embedded',
+      'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-        'mojo_common_lib'
+        'mojo_common_embedded_lib',
+        'mojo_system',
       ],
-      'sources': [
-        'environment/default_async_waiter_impl.cc',
-        'environment/default_async_waiter_impl.h',
-        'environment/default_logger_impl.cc',
-        'environment/default_logger_impl.h',
+      'export_dependent_settings': [
+        '../base/base.gyp:base',
+        '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
       ],
-      'include_dirs': [
-        '..',
+      'sources': [
+        '<@(environment_chromium_sources)',
       ],
     },
     {
@@ -570,6 +597,7 @@
         '../base/base.gyp:base',
         '../base/base.gyp:base_static',
         '../url/url.gyp:url_lib',
+        'mojo_common_lib',
         'mojo_service_manager',
         'mojo_shell_lib',
         'mojo_system_impl',