Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 346583004: crazy_linker: Add support for x86_64. (Closed)

Created:
6 years, 6 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Anton, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

crazy_linker: Add support for x86_64. Add EM_X86_64 and support for x86_64 relocations. BUG=369133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287591

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indentation #

Patch Set 3 : Re-upload after sync/merge to latest #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M third_party/android_crazy_linker/README.chromium View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp View 1 2 4 chunks +56 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/elf_traits.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Anton
lgtm https://codereview.chromium.org/346583004/diff/1/third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp File third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp (right): https://codereview.chromium.org/346583004/diff/1/third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp#newcode419 third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp:419: *target = load_bias_ + addend; The indentation is ...
6 years, 6 months ago (2014-06-18 18:22:46 UTC) #1
simonb (inactive)
Anton: Thanks for the lgtm and note. Ross: Added you as reviewer. Current status: Runs ...
6 years, 6 months ago (2014-06-19 10:21:13 UTC) #2
rmcilroy
lgtm
6 years, 6 months ago (2014-06-19 10:54:56 UTC) #3
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-05 15:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/346583004/60001
6 years, 4 months ago (2014-08-05 15:07:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 19:40:27 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 20:52:02 UTC) #7
Message was sent while issue was closed.
Change committed as 287591

Powered by Google App Engine
This is Rietveld 408576698