Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 346583002: [DevTools] Add groups to device select. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Add groups to device select. This also fixes small UI problems. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176444

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed comments #

Patch Set 3 : UI fixes #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -69 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 1 2 5 chunks +13 lines, -15 lines 0 comments Download
M Source/devtools/front_end/overrides.css View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 2 3 10 chunks +44 lines, -28 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 5 chunks +41 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-18 16:04:17 UTC) #1
pfeldman
https://codereview.chromium.org/346583002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/346583002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode425 Source/devtools/front_end/sdk/OverridesSupport.js:425: WebInspector.OverridesSupport._desktops = [ _notebooks? https://codereview.chromium.org/346583002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode426 Source/devtools/front_end/sdk/OverridesSupport.js:426: ["Chromebook Pixel", We ...
6 years, 6 months ago (2014-06-18 16:15:41 UTC) #2
dgozman
PTAL https://codereview.chromium.org/346583002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js File Source/devtools/front_end/sdk/OverridesSupport.js (right): https://codereview.chromium.org/346583002/diff/1/Source/devtools/front_end/sdk/OverridesSupport.js#newcode425 Source/devtools/front_end/sdk/OverridesSupport.js:425: WebInspector.OverridesSupport._desktops = [ On 2014/06/18 16:15:41, pfeldman wrote: ...
6 years, 6 months ago (2014-06-18 16:25:41 UTC) #3
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 16:26:57 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-18 16:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/346583002/20001
6 years, 6 months ago (2014-06-18 16:28:15 UTC) #6
dgozman
The CQ bit was unchecked by dgozman@chromium.org
6 years, 6 months ago (2014-06-18 16:31:38 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-18 17:02:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/346583002/60001
6 years, 6 months ago (2014-06-18 17:02:56 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 19:16:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 176444

Powered by Google App Engine
This is Rietveld 408576698