Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: public/platform/WebLockOrientationCallback.h

Issue 346543003: Remove WebLockOrientationCallback::ErrorType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_up_callback_errors
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLockOrientationCallback_h 5 #ifndef WebLockOrientationCallback_h
6 #define WebLockOrientationCallback_h 6 #define WebLockOrientationCallback_h
7 7
8 #include "public/platform/WebLockOrientationError.h" 8 #include "public/platform/WebLockOrientationError.h"
9 #include "public/platform/WebScreenOrientationType.h" 9 #include "public/platform/WebScreenOrientationType.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 // WebScreenOrientationType is an interface to be used by the embedder in order 13 // WebScreenOrientationType is an interface to be used by the embedder in order
14 // to inform Blink when a screen lock operation has succeeded or failed. 14 // to inform Blink when a screen lock operation has succeeded or failed.
15 // A success notification comes with the new orientation angle and orientation 15 // A success notification comes with the new orientation angle and orientation
16 // type and a failure notification comes with an information about the type of 16 // type and a failure notification comes with an information about the type of
17 // failure. 17 // failure.
18 class WebLockOrientationCallback { 18 class WebLockOrientationCallback {
19 public: 19 public:
20 enum ErrorType {
21 ErrorTypeNotAvailable, // If locking isn't available on the platform.
22 ErrorTypeFullScreenRequired, // If fullscreen is required to lock.
23 ErrorTypeCanceled, // If another lock/unlock got called before that one ended.
24 };
25
26 virtual ~WebLockOrientationCallback() { } 20 virtual ~WebLockOrientationCallback() { }
27 21
28 virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0; 22 virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
29 23 virtual void onError(WebLockOrientationError) = 0;
30 // FIXME: those methods are defined and not virtual pure to not break the
31 // embedder during the transition period.
32 virtual void onError(ErrorType) { }
33 virtual void onError(WebLockOrientationError) { }
34 }; 24 };
35 25
36 } // namespace blink 26 } // namespace blink
37 27
38 #endif // WebLockOrientationCallback_h 28 #endif // WebLockOrientationCallback_h
OLDNEW
« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698