Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 346503002: DevTools: emulate latency network condition. (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@twin
Project:
chromium
Visibility:
Public.

Description

DevTools: emulate latency network condition. BUG=245436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278468

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -28 lines) Patch
M chrome/browser/devtools/devtools_network_interceptor.h View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_network_interceptor.cc View 1 2 6 chunks +107 lines, -24 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
eustas
6 years, 6 months ago (2014-06-18 08:26:44 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/346503002/diff/40001/chrome/browser/devtools/devtools_network_interceptor.cc File chrome/browser/devtools/devtools_network_interceptor.cc (right): https://chromiumcodereview.appspot.com/346503002/diff/40001/chrome/browser/devtools/devtools_network_interceptor.cc#newcode56 chrome/browser/devtools/devtools_network_interceptor.cc:56: suspended_transactions_.erase(it); Let's use HashMap?
6 years, 6 months ago (2014-06-18 14:40:24 UTC) #2
eustas
https://codereview.chromium.org/346503002/diff/40001/chrome/browser/devtools/devtools_network_interceptor.cc File chrome/browser/devtools/devtools_network_interceptor.cc (right): https://codereview.chromium.org/346503002/diff/40001/chrome/browser/devtools/devtools_network_interceptor.cc#newcode56 chrome/browser/devtools/devtools_network_interceptor.cc:56: suspended_transactions_.erase(it); On 2014/06/18 14:40:24, vsevik wrote: > Let's use ...
6 years, 6 months ago (2014-06-19 09:00:14 UTC) #3
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-19 09:02:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/346503002/60001
6 years, 6 months ago (2014-06-19 09:05:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 17:01:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/164219)
6 years, 6 months ago (2014-06-19 17:01:13 UTC) #7
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-19 18:37:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/346503002/60001
6 years, 6 months ago (2014-06-19 18:39:20 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 20:06:32 UTC) #10
Message was sent while issue was closed. 
Change committed as 278468

Powered by Google App Engine
This is Rietveld 408576698