Android: Remove web_request extension API.

Android: Remove web_request extension API.

BUG=305852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278307

[Yoyo Zhou, 2014-06-18 23:38:54]

LGTM

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
File chrome/browser/net/chrome_extensions_network_delegate.cc (right):

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
chrome/browser/net/chrome_extensions_network_delegate.cc:280: void
ChromeExtensionsNetworkDelegate::ForwardProxyErrors(
Is it necessary to override these?

[Lei Zhang, 2014-06-18 23:44:27]

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
File chrome/browser/net/chrome_extensions_network_delegate.cc (right):

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
chrome/browser/net/chrome_extensions_network_delegate.cc:280: void
ChromeExtensionsNetworkDelegate::ForwardProxyErrors(
On 2014/06/18 23:38:54, Yoyo Zhou wrote:
> Is it necessary to override these?

I could add #ifdefs for these three. Did you have something else in mind?

[Yoyo Zhou, 2014-06-18 23:55:25]

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
File chrome/browser/net/chrome_extensions_network_delegate.cc (right):

https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
chrome/browser/net/chrome_extensions_network_delegate.cc:280: void
ChromeExtensionsNetworkDelegate::ForwardProxyErrors(
On 2014/06/18 23:44:27, Lei Zhang wrote:
> On 2014/06/18 23:38:54, Yoyo Zhou wrote:
> > Is it necessary to override these?
> 
> I could add #ifdefs for these three. Did you have something else in mind?

The NetworkDelegate implementation does nothing here.

[Lei Zhang, 2014-06-18 23:59:11]

On 2014/06/18 23:55:25, Yoyo Zhou wrote:
>
https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
> File chrome/browser/net/chrome_extensions_network_delegate.cc (right):
> 
>
https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
> chrome/browser/net/chrome_extensions_network_delegate.cc:280: void
> ChromeExtensionsNetworkDelegate::ForwardProxyErrors(
> On 2014/06/18 23:44:27, Lei Zhang wrote:
> > On 2014/06/18 23:38:54, Yoyo Zhou wrote:
> > > Is it necessary to override these?
> > 
> > I could add #ifdefs for these three. Did you have something else in mind?
> 
> The NetworkDelegate implementation does nothing here.

ForwardFoo is ChromeNetworkDelegate specific. NetworkDelegate annoyingly have
its virtual functions marked as private.

[Yoyo Zhou, 2014-06-19 00:02:15]

On 2014/06/18 23:59:11, Lei Zhang wrote:
> On 2014/06/18 23:55:25, Yoyo Zhou wrote:
> >
>
https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
> > File chrome/browser/net/chrome_extensions_network_delegate.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/346493002/diff/60001/chrome/browser/ne...
> > chrome/browser/net/chrome_extensions_network_delegate.cc:280: void
> > ChromeExtensionsNetworkDelegate::ForwardProxyErrors(
> > On 2014/06/18 23:44:27, Lei Zhang wrote:
> > > On 2014/06/18 23:38:54, Yoyo Zhou wrote:
> > > > Is it necessary to override these?
> > > 
> > > I could add #ifdefs for these three. Did you have something else in mind?
> > 
> > The NetworkDelegate implementation does nothing here.
> 
> ForwardFoo is ChromeNetworkDelegate specific. NetworkDelegate annoyingly have
> its virtual functions marked as private.

Ah, ok. That's fine then.

[Lei Zhang, 2014-06-19 00:02:57]

Removes 39 KB from the ChromeShell APK, FTR.

[Lei Zhang, 2014-06-19 00:03:00]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-19 00:06:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/346493002/60001

[commit-bot: I haz the power, 2014-06-19 08:44:18]

Change committed as 278307