Issue 346473002: Add missing map check to the optimized version of f.call(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346473002: Add missing map check to the optimized version of f.call(...). (Closed)

Created:
6 years, 6 months ago by Jarin

Modified:
6 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add missing map check to the optimized version of f.call(...). R=verwaest@chromium.org BUG=386034 LOG=N

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
	A	test/mjsunit/regress/regress-386034.js	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jarin

On 2014/06/18 05:17:15, jarin wrote: As Toon suggested offline, the map check for optimized f.apply ...

6 years, 6 months ago (2014-06-18 12:35:25 UTC) #2

lgtm