Issue 346413004: Remove distinction between hidden and normal runtime functions

Issue 346413004: Remove distinction between hidden and normal runtime functions (Closed)

Created:
6 years, 6 months ago by danno

Modified:
6 years, 6 months ago

Reviewers:
Michael Starzinger, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove distinction between hidden and normal runtime functions R=jkummerow@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22018

Patch Set 3 : Fix natives fuzzing #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+764 lines, -643 lines)			Patch
M	src/arm/builtins-arm.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	19 chunks	+19 lines, -20 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		29 chunks	+30 lines, -30 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/builtins-arm64.cc	View		9 chunks	+10 lines, -10 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1	18 chunks	+19 lines, -20 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View		29 chunks	+30 lines, -30 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1	11 chunks	+14 lines, -14 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/full-codegen.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/hydrogen.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	19 chunks	+19 lines, -20 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		29 chunks	+30 lines, -30 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/builtins-mips.cc	View	1	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	19 chunks	+19 lines, -20 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	29 chunks	+30 lines, -30 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/runtime.h	View	1	4 chunks	+86 lines, -91 lines	0 comments	Download
M	src/runtime.cc	View	1	61 chunks	+60 lines, -70 lines	0 comments	Download
M	src/serialize.cc	View	1	2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	19 chunks	+19 lines, -20 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		29 chunks	+30 lines, -30 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x87/builtins-x87.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/x87/code-stubs-x87.cc	View	1	18 chunks	+18 lines, -19 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View		30 chunks	+31 lines, -31 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	1	12 chunks	+14 lines, -14 lines	0 comments	Download
M	src/x87/macro-assembler-x87.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/fuzz-natives/fuzz-natives.status	View	1 2	1 chunk	+63 lines, -0 lines	1 comment	Download
A +	test/mjsunit/runtime-gen/numbertostringrt.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/runtime-gen/regexpconstructresult.js	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
A +	test/mjsunit/runtime-gen/regexpexecrt.js	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
A +	test/mjsunit/runtime-gen/stringcharcodeatrt.js	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/generate-runtime-tests.py	View	1 2	2 chunks	+86 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM if comments are addressed. https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc#newcode68 src/arm/code-stubs-arm.cc:68: Runtime::kCreateArrayLiteralStubBailout)->entry; nit: Does this ...

6 years, 6 months ago (2014-06-24 13:06:06 UTC) #1

danno

Please take another look, specifically I made a bunch of changes so that natives fuzzing ...

6 years, 6 months ago (2014-06-24 16:22:49 UTC) #2

Jakob Kummerow

Test-related changes LGTM with nits. https://codereview.chromium.org/346413004/diff/40001/test/fuzz-natives/fuzz-natives.status File test/fuzz-natives/fuzz-natives.status (right): https://codereview.chromium.org/346413004/diff/40001/test/fuzz-natives/fuzz-natives.status#newcode34 test/fuzz-natives/fuzz-natives.status:34: # TODO(danno): Fix these ...

6 years, 6 months ago (2014-06-24 16:28:09 UTC) #3

danno

6 years, 6 months ago (2014-06-25 15:27:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22018 (presubmit successful).

Expand Messages | Collapse Messages