Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 346413003: Disable use_chromium_linker for profiler (Closed)

Created:
6 years, 6 months ago by JungJik
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable use_chromium_linker for profiler if we use chromium_android_linker, it excludes -finstrument-functions and removes profiling functions. so that we couldn't see buckets data in deep-memory-profiler. Bug=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/chrome_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
JungJik
PTAL :)
6 years, 6 months ago (2014-06-24 11:51:25 UTC) #1
bulach
lgtm, I think it makes sense but please wait for simon :) thanks!
6 years, 6 months ago (2014-06-24 13:53:00 UTC) #2
simonb1
lgtm
6 years, 6 months ago (2014-06-24 15:03:12 UTC) #3
JungJik
On 2014/06/24 15:03:12, simonb1 wrote: > lgtm Thanks for lgtm. :)
6 years, 6 months ago (2014-06-24 16:04:41 UTC) #4
jam
lgtm
6 years, 6 months ago (2014-06-24 18:24:52 UTC) #5
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 6 months ago (2014-06-24 23:49:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/346413003/1
6 years, 6 months ago (2014-06-24 23:51:24 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-25 04:25:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 04:32:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/165845)
6 years, 6 months ago (2014-06-25 04:32:16 UTC) #10
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 6 months ago (2014-06-25 06:37:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/346413003/1
6 years, 6 months ago (2014-06-25 06:38:41 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 10:15:36 UTC) #13
Message was sent while issue was closed.
Change committed as 279662

Powered by Google App Engine
This is Rietveld 408576698