Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 346413002: Rebaseline gm results after "Implement text rendering with NVPR" (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen
Modified:
6 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, jvanverth1, bsalomon, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline gm results after "Implement text rendering with NVPR" Rebaseline gm results after "Implement text rendering with NVPR". The text is rasterized by NV_path_rendering extension, so pixels are expected to be a bit different. NOTRY=true Committed: https://skia.googlesource.com/skia/+/68dd81bde91c61e034702ab957ba4ab42010afa9

Patch Set 1 #

Messages

Total messages: 17 (0 generated)
Kimmo Kinnunen
This should make some of the bots green.
6 years, 6 months ago (2014-06-24 10:32:41 UTC) #1
rmistry
LGTM
6 years, 6 months ago (2014-06-24 10:58:51 UTC) #2
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-24 10:59:44 UTC) #3
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-24 10:59:49 UTC) #4
rmistry
On 2014/06/24 10:59:49, rmistry wrote: > The CQ bit was unchecked by mailto:rmistry@google.com I need ...
6 years, 6 months ago (2014-06-24 11:04:51 UTC) #5
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-24 11:20:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/346413002/1
6 years, 6 months ago (2014-06-24 11:21:32 UTC) #7
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-24 11:38:42 UTC) #8
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-24 11:42:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/346413002/1
6 years, 6 months ago (2014-06-24 11:43:31 UTC) #10
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 6 months ago (2014-06-24 11:44:28 UTC) #11
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-24 11:44:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/346413002/1
6 years, 6 months ago (2014-06-24 11:45:52 UTC) #13
commit-bot: I haz the power
Change committed as 68dd81bde91c61e034702ab957ba4ab42010afa9
6 years, 6 months ago (2014-06-24 11:46:05 UTC) #14
rmistry
On 2014/06/24 11:46:05, I haz the power (commit-bot) wrote: > Change committed as 68dd81bde91c61e034702ab957ba4ab42010afa9 Looks ...
6 years, 6 months ago (2014-06-24 14:52:56 UTC) #15
rmistry
On 2014/06/24 14:52:56, rmistry wrote: > On 2014/06/24 11:46:05, I haz the power (commit-bot) wrote: ...
6 years, 6 months ago (2014-06-24 15:10:59 UTC) #16
Kimmo Kinnunen
6 years, 6 months ago (2014-06-25 07:54:24 UTC) #17
Message was sent while issue was closed.
On 2014/06/24 15:10:59, rmistry wrote:
> On 2014/06/24 14:52:56, rmistry wrote:
> > On 2014/06/24 11:46:05, I haz the power (commit-bot) wrote:
> > > Change committed as 68dd81bde91c61e034702ab957ba4ab42010afa9
> > 
> > Looks like there is still one failing degeneratesegments_ nvprmsaa4 GM:
> > 
> >
>
http://skia-tree-status.appspot.com/redirect/rebaseline-server/static/view.ht...
> 
> I am not sure if this is expected with your change or not, Kimmo could you
> please take a look and rebaseline if it looks ok.

Thanks. There seems to be something odd with the rendering, so I'd rather fix
the oddness than rebaseline the image.

I'm trying to repro the problem. I filed bug 2689 to track the issue. If you can
say which drivers the buildbot is using, that might help the reproducing the
issue.

Powered by Google App Engine
This is Rietveld 408576698