Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: net/quic/quic_dispatcher.cc

Issue 346303006: Removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deleted quic_flags.h include Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_dispatcher.h ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_dispatcher.cc
diff --git a/net/quic/quic_dispatcher.cc b/net/quic/quic_dispatcher.cc
index 280622da381c178db3b7da98592df0c9664d3787..9c07a4f48fb2773249b1ff7257177d63f445a582 100644
--- a/net/quic/quic_dispatcher.cc
+++ b/net/quic/quic_dispatcher.cc
@@ -164,7 +164,6 @@ QuicDispatcher::QuicDispatcher(const QuicConfig& config,
delete_sessions_alarm_(
helper_->CreateAlarm(new DeleteSessionsAlarm(this))),
supported_versions_(supported_versions),
- supported_versions_no_flow_control_(supported_versions),
supported_versions_no_connection_flow_control_(supported_versions),
current_packet_(NULL),
framer_(supported_versions, /*unused*/ QuicTime::Zero(), true),
@@ -182,17 +181,6 @@ void QuicDispatcher::Initialize(QuicPacketWriter* writer) {
writer_.reset(writer);
time_wait_list_manager_.reset(CreateQuicTimeWaitListManager());
- // Remove all versions > QUIC_VERSION_16 from the
- // supported_versions_no_flow_control_ vector.
- QuicVersionVector::iterator it =
- find(supported_versions_no_flow_control_.begin(),
- supported_versions_no_flow_control_.end(), QUIC_VERSION_17);
- if (it != supported_versions_no_flow_control_.end()) {
- supported_versions_no_flow_control_.erase(
- supported_versions_no_flow_control_.begin(), it + 1);
- }
- CHECK(!supported_versions_no_flow_control_.empty());
-
// Remove all versions > QUIC_VERSION_18 from the
// supported_versions_no_connection_flow_control_ vector.
QuicVersionVector::iterator connection_it =
@@ -378,27 +366,17 @@ QuicConnection* QuicDispatcher::CreateQuicConnection(
QuicConnectionId connection_id,
const IPEndPoint& server_address,
const IPEndPoint& client_address) {
- if (FLAGS_enable_quic_stream_flow_control_2 &&
- FLAGS_enable_quic_connection_flow_control_2) {
+ if (FLAGS_enable_quic_connection_flow_control_2) {
DVLOG(1) << "Creating QuicDispatcher with all versions.";
return new QuicConnection(connection_id, client_address, helper_,
writer_.get(), true, supported_versions_);
}
- if (FLAGS_enable_quic_stream_flow_control_2 &&
- !FLAGS_enable_quic_connection_flow_control_2) {
- DVLOG(1) << "Connection flow control disabled, creating QuicDispatcher "
+ DVLOG(1) << "Connection flow control disabled, creating QuicDispatcher "
<< "WITHOUT version 19 or higher.";
- return new QuicConnection(connection_id, client_address, helper_,
- writer_.get(), true,
- supported_versions_no_connection_flow_control_);
- }
-
- DVLOG(1) << "Flow control disabled, creating QuicDispatcher WITHOUT "
- << "version 17 or higher.";
return new QuicConnection(connection_id, client_address, helper_,
writer_.get(), true,
- supported_versions_no_flow_control_);
+ supported_versions_no_connection_flow_control_);
}
QuicTimeWaitListManager* QuicDispatcher::CreateQuicTimeWaitListManager() {
« no previous file with comments | « net/quic/quic_dispatcher.h ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698