Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 346303006: Removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Robbie Shade
Project:
chromium
Visibility:
Public.

Description

Removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 Per-stream flow control is deemed safe at this point (the bug is open due to connection level flow control) so we can kill it off as a part of removing Qv17. removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 Merge internal change: 69784569 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Deleted quic_flags.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -154 lines) Patch
M net/quic/quic_crypto_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_data_stream_test.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M net/quic/quic_dispatcher.h View 2 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 3 chunks +3 lines, -25 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +0 lines, -10 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +0 lines, -10 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +4 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-26 01:51:55 UTC) #1
Ryan Hamilton
6 years, 6 months ago (2014-06-26 15:45:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698