Gamepad: make gamepad events play well with page visibility

Source/modules/gamepad/NavigatorGamepad.h

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  * DAMAGE.
  */
 
 #ifndef NavigatorGamepad_h
 #define NavigatorGamepad_h
 
 #include "core/frame/DOMWindowLifecycleObserver.h"
 #include "core/frame/DOMWindowProperty.h"
 #include "core/frame/DeviceEventControllerBase.h"
+#include "platform/AsyncMethodRunner.h"
 #include "platform/Supplementable.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/WebGamepads.h"
 
 namespace blink {
 class WebGamepad;
 class WebGamepads;
 }
 
 namespace WebCore {
 
 class Document;
+class Gamepad;
 class GamepadList;
 class Navigator;
 class WebKitGamepadList;
 
 class NavigatorGamepad FINAL : public NoBaseWillBeGarbageCollectedFinalized<NavigatorGamepad>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty, public DeviceEventControllerBase, public DOMWindowLifecycleObserver {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorGamepad);
 public:
     static NavigatorGamepad* from(Document&);
     static NavigatorGamepad& from(Navigator&);
     virtual ~NavigatorGamepad();
 
     static WebKitGamepadList* webkitGetGamepads(Navigator&);
     static GamepadList* getGamepads(Navigator&);
 
     WebKitGamepadList* webkitGamepads();
     GamepadList* gamepads();
 
     virtual void trace(Visitor*);
 
     void didConnectOrDisconnectGamepad(unsigned index, const blink::WebGamepad&, bool connected);
 
 private:
     explicit NavigatorGamepad(LocalFrame*);
 
     static const char* supplementName();
 
+    void dispatchOneEvent();
+    void didRemoveGamepadEventListeners();
+
     // DOMWindowProperty
     virtual void willDestroyGlobalObjectInFrame() OVERRIDE;
     virtual void willDetachGlobalObjectFromFrame() OVERRIDE;
 
     // DeviceEventControllerBase
     virtual void registerWithDispatcher() OVERRIDE;
     virtual void unregisterWithDispatcher() OVERRIDE;
     virtual bool hasLastData() OVERRIDE;
     virtual void didUpdateData() OVERRIDE;
     virtual void pageVisibilityChanged() OVERRIDE;
 
     // DOMWindowLifecycleObserver
     virtual void didAddEventListener(LocalDOMWindow*, const AtomicString&) OVERRIDE;
     virtual void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) OVERRIDE;
     virtual void didRemoveAllEventListeners(LocalDOMWindow*) OVERRIDE;
 
     PersistentWillBeMember<GamepadList> m_gamepads;
     PersistentWillBeMember<WebKitGamepadList> m_webkitGamepads;
+    WillBeHeapDeque<Member<Gamepad> > m_pendingEvents;

[tkent, 2014/07/08 23:17:53]

NavigatorGamepad is not garbage-collected on trunk, and Gamepad is
garbage-collected on trunk.  So, This should be
    PersistentHeapDeque<Member<Gamepad> >
on trunk.

Also, NavigatorGamepad will be garbage-collected with ENABLE(OILPAN). So, This
should be
    HeapDeque<Member<Gamepad> >
with ENABLE(OILPAN).

Conclusion:
Add
#define PersistentHeapDequeWillBeHeapDeque WebCore::HeapDeque
#define PersistentHeapDequeWillBeHeapDeque WebCOre::PersistentHeapDeque
to platform/heap/Handle.h like PersistentHeapHashSetWillBeHeapHashSet, and use
PersistentHeapDequeWillBeHeapDeque<Member<Gamepad> > in NavigatorGamepad.

+    AsyncMethodRunner<NavigatorGamepad> m_dispatchOneEventRunner;
 };
 
 } // namespace WebCore
 
 #endif // NavigatorGamepad_h