Issue 346263003: Don't use the empty string as an url in MemoryCacheTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346263003: Don't use the empty string as an url in MemoryCacheTest. (Closed)

Created:
6 years, 6 months ago by Daniel Bratell

Modified:
6 years, 6 months ago

Reviewers:
Nate Chapin, abarth-chromium

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/blink.git@kurlcrash_20140603

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't use the empty string as an url in MemoryCacheTest. MemoryCacheTest relies on KURL doing something useful with an empty string that results in a non-empty string that can be used as hash key for the MemoryCache. Better to not do that because KURL is being changed. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176773

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	Source/core/fetch/MemoryCache.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	Source/core/fetch/MemoryCacheTest.cpp	View		7 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Bratell

abarth, can you please take a look at this? It's a precursor to the KURL ...

6 years, 6 months ago (2014-06-23 17:04:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/346263003/1

6 years, 6 months ago (2014-06-23 18:11:12 UTC) #5

Message was sent while issue was closed.

Change committed as 176773

Expand Messages | Collapse Messages