Chromium Code Reviews| Index: pkg/polymer/lib/src/instance.dart |
| diff --git a/pkg/polymer/lib/src/instance.dart b/pkg/polymer/lib/src/instance.dart |
| index 6660951ebd42a3a8f5a99307d4a7ecd90e6cbd70..840648d39d85b72792a364141552c4005d698dce 100644 |
| --- a/pkg/polymer/lib/src/instance.dart |
| +++ b/pkg/polymer/lib/src/instance.dart |
| @@ -39,6 +39,10 @@ abstract class Polymer implements Element { |
| // Not yet ported: |
| // src/instance/style.js -- blocked on ShadowCSS.shimPolyfillDirectives |
| + // Polymer elements are assumed to be observable. Due to langauge limitations, |
| + // the [Polymer] mixin doesn't directly include [Observable], but this fields |
| + // declares a dependency assumed in the rest of the code below. |
| + Stream<List<ChangeRecord>> get changes; |
|
Siggi Cherem (dart-lang)
2013/10/23 00:51:33
this helps get rid of warnings from dart2js
Jennifer Messerly
2013/10/23 00:56:33
nice. suggestion we chatted about: add "implements
Siggi Cherem (dart-lang)
2013/10/23 01:00:24
Done.
|
| // TODO(jmesserly): should this really be public? |
| /** Regular expression that matches data-bindings. */ |
| @@ -250,7 +254,7 @@ abstract class Polymer implements Element { |
| /** Locate nodes with id and store references to them in [$] hash. */ |
| void marshalNodeReferences(Node root) { |
| if (root == null) return; |
| - for (var n in root.queryAll('[id]')) { |
| + for (var n in (root as dynamic).queryAll('[id]')) { |
|
Siggi Cherem (dart-lang)
2013/10/23 00:51:33
and this too (query is in Document, Element, and D
|
| $[n.id] = n; |
| } |
| } |