pkg/custom_element/lib/polyfill.dart - Issue 34623011: Fixes needed for the deploy step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/custom_element/lib/polyfill.dart

Issue 34623011: Fixes needed for the deploy step. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/custom_element/lib/polyfill.dart

diff --git a/pkg/custom_element/lib/polyfill.dart b/pkg/custom_element/lib/polyfill.dart

index 0d041aad06eeec1e057811c9239eaeedaef066f5..94c4e8b6cb33b06ef28022c4d652e0114635ddc7 100644

--- a/pkg/custom_element/lib/polyfill.dart

+++ b/pkg/custom_element/lib/polyfill.dart

@@ -21,7 +21,9 @@ Future customElementsReady = () {

if (_isReady) return new Future.value();

// Not upgraded. Wait for the polyfill to fire the WebComponentsReady event.

- return document.body.on['WebComponentsReady'].first;

+ // Note: we listen on document (not on document.body) to allow this polyfill

+ // to be loaded in the HEAD element.

+ return document.on['WebComponentsReady'].first;

Siggi Cherem (dart-lang) 2013/10/23 00:51:33 without this some app fail to run in chrome if the

}();

// Return true if we are using the polyfill and upgrade is complete, or if we

« no previous file with comments | « no previous file | pkg/polymer/lib/src/instance.dart » ('j') | pkg/polymer/lib/src/instance.dart » ('J')