media/cast/rtp_sender/rtp_sender.cc - Issue 34623008: Change to calculate the real NTP in TimeTicks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/rtp_sender/rtp_sender.cc

Issue 34623008: Change to calculate the real NTP in TimeTicks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed to use a LazyInstance instead of a Singleton Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/rtp_sender/rtp_sender.cc

diff --git a/media/cast/rtp_sender/rtp_sender.cc b/media/cast/rtp_sender/rtp_sender.cc

index d306c6e7aaa232ff2689d833f8cced3d1eb1f81a..62897145d49a2227267bd5959ee91a7bab6d4126 100644

--- a/media/cast/rtp_sender/rtp_sender.cc

+++ b/media/cast/rtp_sender/rtp_sender.cc

@@ -121,7 +121,8 @@ void RtpSender::RtpStatistics(const base::TimeTicks& now,

// was captured.

uint32 ntp_seconds = 0;

uint32 ntp_fraction = 0;

- ConvertTimeToNtp(now, &ntp_seconds, &ntp_fraction);

+ ConvertTimeToFractions((now - base::TimeTicks()).InMicroseconds(),

miu 2013/10/30 19:33:35 I'm confused: Did you mean to change this, or was

pwestin 2013/10/30 23:14:30 Yes you are correct, good catch

+ &ntp_seconds, &ntp_fraction);

sender_info->ntp_seconds = ntp_seconds;

sender_info->ntp_fraction = ntp_fraction;