Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 34623002: Move the follwing members from HTMLPlugInImageElement to HTMLPlugInElement. (Closed)

Created:
7 years, 2 months ago by tkent
Modified:
7 years, 2 months ago
Reviewers:
Hajime Morrita, hayato
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Move the follwing members from HTMLPlugInImageElement to HTMLPlugInElement. - m_shouldPreferPlugInsForImages and shouldPreferPlugInsForImages() - isImageType() - m_serviceType - m_url This is a part of tasks to merge HTMLPlugInImageELement into HTMLPlugInElement. Only HTMLPlugInImageElement inherits from HTMLPlugInElement. BUG=309978 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M Source/core/html/HTMLPlugInElement.h View 4 chunks +13 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 3 chunks +17 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInImageElement.h View 4 chunks +0 lines, -12 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 3 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
hayato-san, morrita-san, would you review this please? This is the first step to support author ...
7 years, 2 months ago (2013-10-22 07:30:58 UTC) #1
hayato
lgtm
7 years, 2 months ago (2013-10-22 07:46:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/34623002/1
7 years, 2 months ago (2013-10-22 07:48:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=9194
7 years, 2 months ago (2013-10-22 09:11:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/34623002/1
7 years, 2 months ago (2013-10-22 09:14:15 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 11:19:14 UTC) #6
Message was sent while issue was closed.
Change committed as 160185

Powered by Google App Engine
This is Rietveld 408576698