Issue 346223007: Do not eagerly update allow_osr_at_loop_nesting_level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346223007: Do not eagerly update allow_osr_at_loop_nesting_level. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Do not eagerly update allow_osr_at_loop_nesting_level. Having debug break points prevents OSR. That causes allow_osr_at_loop_nesting_level and the actually patched state to go out of sync. R=jkummerow@chromium.org BUG=387599 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=21958

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -67 lines)			Patch
M	src/full-codegen.h	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/full-codegen.cc	View	1	7 chunks	+10 lines, -12 lines	0 comments	Download
M	src/globals.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View	1	3 chunks	+9 lines, -15 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download
M	src/runtime-profiler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime-profiler.cc	View	1	5 chunks	+9 lines, -17 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-387599.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. https://codereview.chromium.org/346223007/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/346223007/diff/1/src/globals.h#newcode149 src/globals.h:149: const int kIntSizeLog2 = 3; are ...

6 years, 6 months ago (2014-06-23 15:29:23 UTC) #2

Yang

6 years, 6 months ago (2014-06-24 09:32:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21958 (presubmit successful).

Expand Messages | Collapse Messages