Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 346213004: Use IDL argument default values for Text()/Comment() constructors (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-putforwards-attributes
Project:
blink
Visibility:
Public.

Description

Use IDL argument default values for Text()/Comment() constructors The 'data' argument should default to "", not null. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/dom/Comment.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
PTAL There's an isNull() check in CharacterData's constructor (in CharacterData.h) that might not be needed ...
6 years, 6 months ago (2014-06-26 15:14:57 UTC) #1
haraken
OK, this doesn't change web-exposed behavior. LGTM.
6 years, 6 months ago (2014-06-26 15:36:16 UTC) #2
Jens Widell
On 2014/06/26 15:36:16, haraken wrote: > OK, this doesn't change web-exposed behavior. No, the actual ...
6 years, 6 months ago (2014-06-26 15:40:35 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-26 16:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/346213004/1
6 years, 6 months ago (2014-06-26 16:10:31 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 19:14:58 UTC) #6
Message was sent while issue was closed.
Change committed as 177016

Powered by Google App Engine
This is Rietveld 408576698